action: make working-directory optional - #25
Open
thaJeztah wants to merge 1 commit into
Open
Conversation
The action currently sets GOPATH to github.workspace to make its installed helper commands available. This causes projects checked out at the workspace root to fail with "$GOPATH/go.mod exists but should not", forcing callers to use a legacy GOPATH-style checkout path. Install the helper commands in a dedicated directory under runner.temp and add that directory to PATH without modifying the caller's GOPATH. Default working-directory to "." so projects using a standard root checkout do not need to configure it, while retaining support for projects located in a subdirectory. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/go-runc
that referenced
this pull request
Aug 22, 2026
testing containerd/project-checks#25 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
@AkihiroSuda @estesp PTAL 🤗 Tested in |
AkihiroSuda
reviewed
Aug 22, 2026
| # | ||
| # steps: | ||
| # - uses: actions/setup-go@v3 | ||
| # - uses: actions/checkout@v7 |
Member
There was a problem hiding this comment.
Seems to be irrelevant changes
Member
Author
There was a problem hiding this comment.
Ah, yes; I wanted to make sure the example use was correct, and setup-go uses state of the branch as default (at least go.mod) which is why it swapped the order; as the line was now modified, als updated to something more current.
Let me know if you want me to revert and move separate
AkihiroSuda
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The action currently sets GOPATH to github.workspace to make its installed helper commands available. This causes projects checked out at the workspace root to fail with "$GOPATH/go.mod exists but should not", forcing callers to use a legacy GOPATH-style checkout path.
Install the helper commands in a dedicated directory under runner.temp and add that directory to PATH without modifying the caller's GOPATH.
Default working-directory to "." so projects using a standard root checkout do not need to configure it, while retaining support for projects located in a subdirectory.